cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
698 stars 272 forks source link

Attempting to access vehicle controls `^` while remotely accessing vehicle crashes game #5413

Open ZChris13 opened 1 month ago

ZChris13 commented 1 month ago

Describe the bug

Attempting to access the vehicle controls menu '^' while remotely controlling a vehicle crashes the game. This occurs both with the CBM and the item vehicle controller, and regardless of if you're in the vehicle or not, if you're standing on vehicle controls or not.

Steps To Reproduce

  1. Have both a remotely controllable vehicle and a remote vehicle controller
  2. control the vehicle
  3. attempt to access controls

Screenshots

No response

Versions and configuration

Additional context

This occurs without fail on a new save with no mods, and no crash log is generated.

ZChris13 commented 1 month ago

Update: this only happens with drive by wire controls, automatic street sweepers only have the robot driving unit and give the response "No vehicle controls found".

Zlorthishen commented 4 weeks ago

Steps to reproduce the bug

ZChris13 commented 4 weeks ago
  • start new world, spawn in any vehicle, and the items drive-by-wire controls and remove vehicle controller

the bubble car and the solar car have it by default, saves you some button presses

Zlorthishen commented 4 weeks ago

the bubble car and the solar car have it by default, saves you some button presses

i tried that next, i also verified it happens on motorcycles and helicopters, so I assume its all vehicles

ZChris13 commented 4 weeks ago

in the code all vehicles are the same, that shouldn't have any impact you could do it with a portable generator and it'll have the same effect

I got back into this with some more testing and this portable generator I had lying around gives the "no vehicle controls found" message, which is not what I expected image

I get different results while standing next to it vs standing away from it, it appears that using ^ acts from the player? While controlling my helicopter and standing next to the generator, pressing ^ causes me to access the generator's controls.

I am suddenly failing to reproduce this

Okay, it still crashes when I teleport back to my deathmobile and attempt it on that. Now to isolate what's different here.

ZChris13 commented 4 weeks ago

image

now performing the actions with my gyrocopter here is returning a "No vehicle controls found" message, which is not ideal (I would prefer to be able to disconnect and/or turn it off) but doing the same with the deathmobile still results in a crash.

ZChris13 commented 4 weeks ago

image failure to reproduce, and the controls menu is working as expected??? I note that this is a different gyrocopter from the previous post, I have one at base and one on the mobile deathmobile base bike rack. not really relevant to the bug but vehicles with electronics control units give the "no vehicle controls found" message while vehicles with dashboards bring up the menu it seems to only be crashing on the very complicated vehicles with lots of widgets.

alright, I'm going to need a fresh install and world to try to pin this down lol