cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
700 stars 272 forks source link

Dairy free delux sandwitch made with smoked Veggy sausage counts as having meat in it despite containing NO meat. #5613

Open Proxiehunter opened 4 weeks ago

Proxiehunter commented 4 weeks ago

Describe the bug

The Dairy Free Deluxe Sandwich displays the message "The thought of eating this makes you sick" when an herbivore attempts to eat the sandwich, even when the sandwich contains no meat.

I assume this is because the sandwich is tagged as containing flesh even when made with no meat products. Either the sandwich should only be flagged as containing flesh if it actually contains flesh (similar to how things don't get tagged as containing human flesh if not actually made with humans) or the vegetarian version needs to be it's own recipe that isn't flagged as containing flesh (the "Vegan Deluxe Sandwich" maybe). Not sure which is easier.

Steps To Reproduce

1: Make a dairy free deluxe sandwich using veggy sausage (I used smoked, I assume the result would be the same with other versions).

2: Attempt to eat the sandwich with a character who is an herbivore or has meat intolerance.

3: The game should inform you that the thought of eating it makes you sick despite the sandwich containing no meat.

Screenshots

Here you can see it telling you the thought of eating the sandwich will make my character sick.

image

Here you can see that the sandwich is made from bread, dehydrated vegetables, seasoned salt, and smoked veggy sausage. All ingredients an herbivore character should be able to eat.

image

And here I have temporarily turned off my herbivore mutation through the cheat menu to show that the Dairy Free Deluxe Sandwich is superior to the simpler Veggy Sandwich made with smoke veggy sausage by 30 calories and 8 joy. So there's a decent reason to fix this instead of just not making the deluxe version if your character can't eat meat.

image

Versions and configuration

Additional context

No response

ZChris13 commented 4 weeks ago

similar issues with making sandwiches with cornbread for wheat-free survivors is there a reason it's not all just inheriting the tags from the ingredients? at a glance, I guess some of the condiments count as junk food and you don't want your sandwich to inherit that

chaosvolt commented 4 weeks ago

It just hasn't been coded in currently. Food items inherit calories and vitamins presently, but materials are still set by the item itself.

RoyalFox2140 commented 4 weeks ago

We need to port vitamin based allergies so food material does nothing on allergies and instead food inherits a vitamin that makes people sick. That way we could avoid stuff like gluten by vitamins and we would avoid a lot of these problems. https://github.com/CleverRaven/Cataclysm-DDA/pull/74763