cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
700 stars 272 forks source link

fix: stinger dagger no longer uses nonexistent on-hit spell, other consistency fixes for monster weapons #5706

Closed chaosvolt closed 1 week ago

chaosvolt commented 1 week ago

Checklist

Required

Optional

Purpose of change

A few consistency fixes and updates set aside for monster hunter weapons.

Describe the solution

  1. Gave sharktooth leiomano fine cutting 1, same as razor macuahuitl, since it was overriding the regular version only to give it the same qualities.
  2. Set stinger dagger to use the same weight and damage modifiers other monster hunter weapons tend to use instead of being identical to the dagger it inherits from.
  3. Removed hammering quality from recipes for stinger arrows/bolts to be consistent with stinger dagger recipe.
  4. Moved fix for stinger dagger's on-hit spell not actually existing from https://github.com/cataclysmbnteam/Cataclysm-BN/pull/5704 so it can hopefully get merged sooner. No sense having it tied in with a heavier balance tweak.

Describe alternatives you've considered

Removing hammering from tooth recipes because why are you knapping teeth? Also the sharktooth cestus doesn't use it...

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Re-tested stinger dagger to once again confirm the on-hit effect triggers.

Additional context