Open Zlorthishen opened 6 days ago
Autofix has formatted code style violation in this PR.
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.
i get evac center needing to be unique n because of unique npcs it spawns, but may i ask why military bases and aircraft carrier need be globally unique?
Generally speaking I'm ok with adding more specific military locations and tying them into quests than just having a single generic military base.
If we want to go with players being able to access military loot sustainably we can add national guard armories and an airbase, plus garrisons.
The carrier is a bit of a weird one as finding several carriers in lakes would be more of a stretch than finding one.
i get evac center needing to be unique because of unique npcs it spawns, but may i ask why military bases and aircraft carrier need be globally unique?
those were just from the original dda pr, but there are probably a few other locations that could be Globally Unique
edit: I removed the flag from the military base, because it isn't unique enough to be a one-off location
Testing in build 2024-11-14
:
Testing in compiled PR:
Both tests done with default world settings. Only having it fail to generate once is arguably not fatal to this PR since the sample size is low enough and the carrier scenario is suspected to do this occasionally even without this PR, but the crash is definitely concerning.
I've yet to get it to crash again to try and grab more info, but I did just get four failures to generate in a row.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Co-Authored-By
in the commit message.doc/
folder.-->
Purpose of change
ports dda change
Describe alternatives you've considered
Testing
Made multiple characters spawn at the aircraft carrier and military base, all characters spawned at the same locations in the world. Also made those characters get the "Go to the Evac Center" mission, and it directed the characters to the same evac center.
Additional context