Restore removed content

[Firestorm01X2]

Restore removed content

Noticable amount of original content were removed from cdda. It might be good idea to start restoring it.

Describe the solution you'd like

There is very convenient repository with (presumably) all removed contents availible via mods. https://github.com/chaisawlajatang/Cataclysm-DDA-Mods

Silly and nonsense content, removed from the mainline. Atomic cars, fusion blaster CBM&craftable gun, craftable bows, control laptop, handmade guns (raiguns, pneumatic guns etc), laser turrets (they may spawn at military outposts again), Leadworks&Rivtech guns, poor student profession, quantum panels, tankbots, chickenbots and sewer brew&tainted tornado. Also includes flaming weapons, underbarrel flamer, CBM internal storage (currently not possible to add these in nested container version)

It is very conveniently organized and structured. It is even has separate directory for non-pocket version (https://github.com/chaisawlajatang/Cataclysm-DDA-Mods/tree/master/Removed%20content%20non-pocket). So it should be used as starting point of resotre contents.

Additinaly some things, that presented as mods in this repo already were tweaked in BN.

Probably it is better to restore contents in relatively small chunks via separate PRs to make all restore process more controllable.

[Coolthulhu]

• Drugs - already restored, may need more balancing since meth is currently rather OP
• CBM fusion blaster - would require rewriting the arm limitations and I don't think it's worth it, as the CBM kinda sucked for its cost
• Bow recipes - we need to cut down on the number of bows first
• Craftable guns - those sound fine, though need rebalancing, as their stats are pathetically weak, making the guns only useful for grinding skills
• Control laptop - not too sure about this one. Big game changer.
• Laser turret - cheap lasers are a significant change to balancing, as they allow building 1 tile city cleaner gun carts. I'd like something like this to be a thing eventually, but I'd delay it until melee stops being tedious.
• Leadworks - they'd need some modification to stand out more. I'd skip those and just fiddle with existing guns.
• Poor student - we've got enough -1 professions
• Quantum panel - I don't think it makes enough of a difference to bother with it
• Robots - they'd need a new in-game role. Without an AI to make them protect an area, they're just an instakill waiting to happen.
• Sewer brew - already in
• Storage CBM - it always sucked
• Atomic car - maybe? If reactors are still working. Didn't check.
• Flaming weapons - they always sucked, would need a rewrite from the code side, but only after figuring out how would they work
• Underbarrel flamer - flamethrowers kinda suck due to their loot destroying properties, this would need to change first

[Firestorm01X2]

*Robots - they'd need a new in-game role. Without an AI to make them protect an area, they're just an instakill waiting to happen.

However "creating chaos "part may be fun. Robots can be nerfed via long aiming time or less accurate guns. Turrets actually somewhat that case also,

Leadworks - they'd need some modification to stand out more. I'd skip those and just fiddle with existing guns.

Some people liked certain Leadwork guns. They should be a lot atteactable now due a lof of built in attachments with good quality. You've probably missed rework: https://github.com/CleverRaven/Cataclysm-DDA/pull/24187 . They had this modifictions long time ago,

[Coolthulhu]

However "creating chaos "part may be fun.

Watching a tank spam grenades at zombies is only fun for a while. Having one come around the corner while you're in the open is guaranteed death. Plus they wreck stuff and cars, but only when in the bubble.

Robots can be nerfed via long aiming time or less accurate guns.

This wouldn't do much until it was so long that you could cheese them by getting out of their LOS after sniping them. And then it would make them cheeseable. There's also that issue of them having a ton of ammo, like turrets pre-nerf. Should they run out of ammo, drop a ton of ammo or what?

They need an in-game role, otherwise they are there just because. Without understanding what they are supposed to do, they can't be tailored to do that thing.

You've probably missed rework

I checked the one in Lajatang's repo. Regarding the ones in your rework:

• Different set of Leadworks-specific attachments is a no-go. They have to use the common ones or none at all.
• Having them come with non-removable attachments is an idea, but it would be much better to apply the changes from those attachments to base gun and remove the attachment, where possible. For example, if the gun comes in with a modified grip, scrap the grip and just apply the changes from the grip to the stats of the base gun, so that the end result doesn't differ, but mod list is one entry shorter.
• They will still need a balancing pass. The two most important questions are: When would you want to use them? When would you not want to use them over a similar tier+caliber alternative? Ideally with examples of "worse" and "better" weapons for both cases.

[Firestorm01X2]

So, for now allowed to restore stuff are:

• Craftable guns;
• Atomic car.

[Coolthulhu]

Craftable guns yes, but they'll need balancing when getting in. The usual questions.

Atomic car is probably fine to reintroduce as-is.

[Firestorm01X2]

@Coolthulhu , Sorry. I've attached wrong issue. Please, reopen current issue and close this: https://github.com/cataclysmbnteam/Cataclysm-BN/issues/66

[Firestorm01X2]

Control laptop is still in BN. It was removed from DDA shortly after BN was forked: https://github.com/CleverRaven/Cataclysm-DDA/pull/40423

[Coolthulhu]

The outline is provided, design document describes the criteria for restoration. The issue can be considered resolved. For specific content to be restored, separate, individual issues or PRs should be opened.