cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
685 stars 268 forks source link

Some tests fail because of RNG #736

Open Coolthulhu opened 3 years ago

Coolthulhu commented 3 years ago

When adding certain features, I altered some of the tests, but without enough precision, so they randomly fail.

olanti-p commented 2 years ago

Some player temperature test also started to fail, example from https://github.com/cataclysmbnteam/Cataclysm-BN/runs/7958233612 run on #1801

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cata_test is a Catch v2.13.8 host application.
Run with -? for options

Randomness seeded to: 1661192385

-------------------------------------------------------------------------------
Player body temperatures within expected bounds.
-------------------------------------------------------------------------------
player_test.cpp:284
...............................................................................

player_test.cpp:281: FAILED:
  REQUIRE( p.body_wetness == decltype( p.body_wetness )() )
with expansion:
  { 0, 0, 0, 0, 0, 0, 0, 0, 2, 2, 2, 2 }
  ==
  { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }
olanti-p commented 2 years ago

And vehicle split tests, example from https://github.com/cataclysmbnteam/Cataclysm-BN/runs/7932860706 run on #1793

-------------------------------------------------------------------------------
vehicle_split_section
-------------------------------------------------------------------------------
vehicle_split_test.cpp:13
...............................................................................

vehicle_split_test.cpp:30: FAILED:
  REQUIRE( veh_ptr != nullptr )
with expansion:
  nullptr != nullptr