cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
669 stars 265 forks source link

Hobo Stove Duplication #981

Closed GreyGoldFish closed 2 years ago

GreyGoldFish commented 2 years ago

Describe the bug

Whenever you deploy a Hobo Stove, you duplicate it, ending up with one Hobo Stove with one less tinder in your inventory, and another with 0 tinder on the floor.

Steps To Reproduce

  1. Craft Hobo Stove.
  2. Recharge it with any amount of tinder.
  3. Press 'a' and then deploy Hobo Stove.
  4. Pick up Hobo Stove.
  5. Check inventory. You now have two Hobo Stoves.

Expected behavior

Deploying the Hobo Stove should remove it from your inventory without consuming one tinder and without duplicating the item. As it is right now, it's impossible to use the Hobo Stove at all.

Versions and configuration


08:45:32.724 : Starting log. 08:45:32.724 INFO : Cataclysm BN version 52abc90 08:45:32.733 INFO : C locale on startup: 'C' 08:45:32.733 INFO : C++ locale on startup: 'C' 08:45:32.734 INFO : Detected system UI language as 'en_US' 08:45:32.734 INFO : SDL version used during compile is 2.0.14 08:45:32.735 INFO : SDL version used during linking and in runtime is 2.0.14 08:45:33.409 INFO : Number of render drivers on your system: 5 08:45:33.410 INFO : Render driver: 0/direct3d 08:45:33.410 INFO : Render driver: 1/direct3d11 08:45:33.410 INFO : Render driver: 2/opengl 08:45:33.410 INFO : Render driver: 3/opengles2 08:45:33.411 INFO : Render driver: 4/software 08:45:33.435 INFO : Active renderer: 1/direct3d11 08:45:33.572 INFO : Active audio driver: wasapi 08:45:33.591 INFO : Opened mixer with specs: 44100 Hz, 2 channel(s), format 0x8010 08:45:35.160 INFO : Using experimental system, language set to 'en_US' 08:45:35.160 INFO : C locale set to 'English_United States.1252' 08:45:35.160 INFO : C++ locale set to 'C' 08:45:36.125 WARNING : opendir [./mods/] failed with "No such file or directory". 08:48:47.069 WARNING : opendir [./save/Keter/mods/] failed with "No such file or directory". 08:48:58.484 INFO : Loaded tileset: UNDEAD_PEOPLE_BASE 08:49:08.293 INFO : GAME REPORT:

08:49:10.998 : Log shutdown.

chaosvolt commented 2 years ago

This is most likely a problem caused by MST Extra's override to hobo stoves converting it to a deployable fire container instead of a hotplate that can't cook.

DDA eventually copied the same general idea with https://github.com/CleverRaven/Cataclysm-DDA/pull/49442 so I might port it over, though probably fix the recipe to not be so fake-realistic with how it restricts the player to drilling holes instead of just punching holes in it like with fire barrels.