search

catacombing / kumo

A Wayland Mobile Browser
GNU General Public License v3.0
8 stars 1 forks source link

Move tabs UI to overlay surface #23

Closed chrisduerr closed 1 month ago

chrisduerr commented 1 month ago

Currently Kumo has three surfaces, UI, Engine, and Tabs. However there's a need for rendering popups, which generally can be combined with the tabs UI surface to avoid excessive surfaces.

This is likely best done with a src/ui/overlay/mod.rs module, which provides the basics for rendering generic texture+position, then have src/ui/overlay/tabs.rs to implement that trait and handle dispatching of events like touch. Some z-index might be useful too, though with just popups/tabs there should not be a need for it since only one popup or the tabs UI is generally visible. However having the ability to show two popups might be best for future-compat, so something like popups: Vec<Box<dyn Popup>> maybe.

chrisduerr commented 1 month ago

Fixed in 0c259c3ce6f6b9eaa98e8d75f2a55ab7440a8d1c.