search

catalinghita8 / android-mvvm-rxjava2-dagger2

This repository contains a detailed sample application that uses MVVM as its presentation layer pattern. Essential dependencies are Dagger2 with Dagger-android, RxJava2 with RxAndroid, Room, Retrofit and Espresso.
65 stars 17 forks source link

Clicking Quake fragment causes app to crash #1

Closed MiguelAlexRamirez closed 4 years ago

MiguelAlexRamirez commented 4 years ago

very helpful pedagogical example, it seems to crash when attempting to click a single quake fragment and be redirected tot he URL specified

catalinghita8 commented 4 years ago

Hi @MiguelAlexRamirez,

I will have a look into and see what's causing the crash. Can you please give me more details on what device and Android API level have you encountered this?

Thanks, Catalin

catalinghita8 commented 4 years ago

I was unable to reproduce this.

Please post a stacktrace.

MiguelAlexRamirez commented 4 years ago

First and foremost thank you so much for the prompt replies in trying to help out, the project has been super helpful with learning android concepts, below is a photo of the stacktrace which occurs when clicking on a singular quake fragment -> URL

Various posts state that the nature of the error resides in the fact that the intent needs certain flags declared but when I attempted to do that with the CustomTabIntent without any luck. I have attempted it using an emulator Nexus 5X API 29 and a note 9 running API 28

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Sunday, March 1, 2020 10:25 AM, catalinghita8 notifications@github.com wrote:

I was unable to reproduce this.

Please post a stacktrace.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

MiguelAlexRamirez commented 4 years ago

I just realized the attachment was sent via proton mail and doesn't seem to be appearing here, my apologies stack_trace

catalinghita8 commented 4 years ago

@MiguelAlexRamirez I was able to reproduce the issue now. Thanks. Please check the fixes in 77d21914bc42fb07693f45ea16cd3847a1a205b5 .

Also get the latest version on master branch and it should no longer crash on API 29+.