Channel names missing in web interface

[9000h]

https://github.com/catalinii/minisatip/blob/08c374bab421211df913a061c2fd35e7980eae54/src/pmt.c#L2255 should it be not strlcatf(dest, max_size, pos, "%s,", pmt->name); but it shows then all channels on the freq

[catalinii]

Fixed in master

[9000h]

@catalinii thanks for looking in to, channel names in the status page are now correct for encrypted channels but there are no channel names shown on FTA channels

[Jalle19]

I second this, I'm getting no channel names at all with v1.2.34. @catalinii

[catalinii]

This should be fixed in the master

[Jalle19]

I still have no channel names. This is on an FTA channel.

[9000h]

did you also use the new status.html?

[Jalle19]

Hmm, no 😄 I'll report back

[Jalle19]

Still the same issue even after updating the html directory contents

[Jalle19]

Not sure if this is related:

pmt.c: In function ‘pmt_pid_add’:
pmt.c:2221:11: warning: unused variable ‘pmt’ [-Wunused-variable]
 2221 |     SPMT *pmt = NULL;
      |           ^~~

I tried the latest master locally too and it has the same issue, so any problems with my production setup can be ruled out.

[9000h]

hmm, I run it on Intel hardware maybe happened on different CPU type

[Jalle19]

Actually I'm on Intel too 🤷 I'll start bisecting my way back to the last working version.

[9000h]

hmm, I do have no CI in my system atm

[Jalle19]

aacfffe44346f614baa132b89b3aa2ddfb3aac99 is the first bad commit
commit aacfffe44346f614baa132b89b3aa2ddfb3aac99
Author: Catalin Toda <catalinii@yahoo.com>
Date:   Tue Oct 4 17:09:03 2022 -0700

    Add fe= to the Web UI URL only if requested by the client #966

 html/status.html | 117 +++++++++++++++---------
 src/adapter.c    |   5 +-
 src/adapter.h    |   5 +
 src/ca.c         |  18 +++-
 src/ddci.c       |   3 +
 src/dvb.c        |  13 +--
 src/dvbapi.c     |  21 ++---
 src/pmt.c        | 271 +++++++++++++++++++++++++++++++++----------------------
 src/pmt.h        |   5 +-
 src/tables.c     |  57 +-----------
 src/tables.h     |   6 --
 src/utils.h      |   6 +-
 12 files changed, 287 insertions(+), 240 deletions(-)

[catalinii]

@Jalle19 can u check the latest master?

[Jalle19]

Yes, now it finally works! :pray: