catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
325 stars 78 forks source link

Automated Debian packaging #1013

Closed Jalle19 closed 1 year ago

Jalle19 commented 1 year ago

Have to PR this to run the GitHub workflow, still work in progress

Jalle19 commented 1 year ago

So okay, this needs to be triggered after the release tagging, otherwise git describe --tags will pick up the previous tag.

Jalle19 commented 1 year ago

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release should use this

Jalle19 commented 1 year ago

Then we need to figure out a repository etc. too.

lars18th commented 1 year ago

Hi @Jalle19 ,

Check my comment about the incorrent name in the "debian/gen_changelog" file. 😉

Jalle19 commented 1 year ago

Gonna have to try the produced package in a VM before merging this

Jalle19 commented 1 year ago

Installation seems to go well:

vagrant@ubuntu-focal:/vagrant$ sudo dpkg -i minisatip_1.2.43-6-gfbce4c9-fbce4c9_amd64.deb 
Selecting previously unselected package minisatip.
(Reading database ... 68936 files and directories currently installed.)
Preparing to unpack minisatip_1.2.43-6-gfbce4c9-fbce4c9_amd64.deb ...
Unpacking minisatip (1.2.43-6-gfbce4c9-fbce4c9) ...
dpkg: dependency problems prevent configuration of minisatip:
 minisatip depends on libdvbcsa1 (>= 1.1.0); however:
  Package libdvbcsa1 is not installed.

dpkg: error processing package minisatip (--install):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 minisatip
vagrant@ubuntu-focal:/vagrant$ sudo apt-get -f install
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Correcting dependencies... Done
The following additional packages will be installed:
  libdvbcsa1
The following NEW packages will be installed:
  libdvbcsa1
0 upgraded, 1 newly installed, 0 to remove and 191 not upgraded.
1 not fully installed or removed.
Need to get 21.4 kB of archives.
After this operation, 81.9 kB of additional disk space will be used.
Do you want to continue? [Y/n] 
Get:1 http://archive.ubuntu.com/ubuntu focal/universe amd64 libdvbcsa1 amd64 1.1.0-2build1 [21.4 kB]
Fetched 21.4 kB in 1s (32.6 kB/s)     
Selecting previously unselected package libdvbcsa1:amd64.
(Reading database ... 68970 files and directories currently installed.)
Preparing to unpack .../libdvbcsa1_1.1.0-2build1_amd64.deb ...
Unpacking libdvbcsa1:amd64 (1.1.0-2build1) ...
Setting up libdvbcsa1:amd64 (1.1.0-2build1) ...
Setting up minisatip (1.2.43-6-gfbce4c9-fbce4c9) ...
adduser: Warning: The home directory `/var/lib/minisatip' does not belong to the user you are currently creating.
Created symlink /etc/systemd/system/sockets.target.wants/minisatip.path → /lib/systemd/system/minisatip.path.
Created symlink /etc/systemd/system/multi-user.target.wants/minisatip.service → /lib/systemd/system/minisatip.service.
Processing triggers for libc-bin (2.31-0ubuntu9.2) ...
Jalle19 commented 1 year ago

After some minor tweaks the systemd unit is running nicely:

vagrant@ubuntu-focal:/lib/systemd/system$ sudo systemctl status minisatip
● minisatip.service - minisatip - a multi-threaded SAT>IP server
     Loaded: loaded (/lib/systemd/system/minisatip.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2022-11-07 20:02:55 UTC; 2s ago
TriggeredBy: ● minisatip.path
   Main PID: 18395 (minisatip)
      Tasks: 3 (limit: 1136)
     Memory: 704.0K
     CGroup: /system.slice/minisatip.service
             └─18395 /usr/bin/minisatip -f

Nov 07 20:02:55 ubuntu-focal systemd[1]: Started minisatip - a multi-threaded SAT>IP server.
Nov 07 20:02:55 ubuntu-focal minisatip[18395]: [07/11 20:02:55.264 main]: minisatip version 1.2.~fbce4c9, compiled in Nov  7 2022 19:45:49, with s2api version: 050B
Nov 07 20:02:55 ubuntu-focal minisatip[18395]: [07/11 20:02:55.324 main]: Initializing with 0 devices

Version number is still wrong though, will need some more investigating

Jalle19 commented 1 year ago

Changed the workflow to be triggered by new releases being published, that should fix the versioning. Let's merge this and figure out the next steps.

Jalle19 commented 1 year ago

https://github.com/orgs/community/discussions/26875#discussioncomment-3253761 apparently this is the reason why the action is not being triggered now... Hard to get these GitHub actions right it seems.

Yuri666 commented 1 year ago

Why we need vdr and vdr-plugins to minisatip debian packaging? I suggest to remove vdr depency.

Jalle19 commented 1 year ago

It's for buiilding with mcli-plugin or whatever it's called