This is a request to comment for a new functionality that I want to implement in minisatip. The concept is "pass specific commands in requests". Here a simple description:
When you do a request, using RTSP or HTTP protocols, a new enhancement will be provided to pass some specific commands to the concrete minisatip instance. For example, if you want to add some pids based on PMT tables, enable or disable decryption, pass information about master/slave use, etc.
My proposal is based on this: https://github.com/catalinii/minisatip/issues/992#issuecomment-1399419859
And it will be useful to solve issues like #1049, #856, #811, #992, etc.
However, this RFE is only about how to pass these requests, and not about the specific commands. Therefore, the idea is to implement first the method to pass the requests extensions, and after then we'll try to implement the specific commands. I hope you agree with this proposed roadmap.
Now my proposal (open to discussion):
Provide two ways to pass the information: inside the URL request, and as additional header. The idea is to use mainly the second method, but provide the first one as a convenience (useful for example with HTTP clients that only provide the option of edit the URL).
As you can see the two methods can pass the same information. In the URL format I suggest to use the tag x_msatip_cmd!<label>=<value>. And in the Header format X_MSATIP_CMD: <label1>=<value1>&<label2>=<value2>&.... Note that in the URL format the tag could be repeated multiple times.
If you agree with the previous, then I'll implement this in the code inside the functions that are parsing the RTSP/HTTP requests. And I'll put all the extension commands inside a tuple-vector with the labels and values. All parsed for convenience. And without checking for repetitions. After achieve this goal the idea will be to convert these values to concrete internal variables to use them.
What you think about this?
You want to participate in the implementation?
Hi,
This is a request to comment for a new functionality that I want to implement in minisatip. The concept is "pass specific commands in requests". Here a simple description:
My proposal is based on this: https://github.com/catalinii/minisatip/issues/992#issuecomment-1399419859 And it will be useful to solve issues like #1049, #856, #811, #992, etc. However, this RFE is only about how to pass these requests, and not about the specific commands. Therefore, the idea is to implement first the method to pass the requests extensions, and after then we'll try to implement the specific commands. I hope you agree with this proposed roadmap.
Now my proposal (open to discussion):
...&x_msatip_cmd!pnr=1000&x_msatip_cmd!slave=onX_MSATIP_CMD: pnr=1000&slave=onAs you can see the two methods can pass the same information. In the URL format I suggest to use the tag
x_msatip_cmd!<label>=<value>. And in the Header formatX_MSATIP_CMD: <label1>=<value1>&<label2>=<value2>&.... Note that in the URL format the tag could be repeated multiple times.If you agree with the previous, then I'll implement this in the code inside the functions that are parsing the RTSP/HTTP requests. And I'll put all the extension commands inside a tuple-vector with the labels and values. All parsed for convenience. And without checking for repetitions. After achieve this goal the idea will be to convert these values to concrete internal variables to use them.
What you think about this? You want to participate in the implementation?