search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
324 stars 78 forks source link

Don't manipulate PMT IDs in the filter even when clean_psi is not used #1065

Closed Jalle19 closed 1 year ago

Jalle19 commented 1 year ago

Been running this locally for some time, haven't at least noticed any side effects.

Jalle19 commented 1 year ago

Mentioned here https://github.com/catalinii/minisatip/issues/949#issuecomment-1337858224

catalinii commented 1 year ago

clean_psi is broken, but other than that I am fine with it.

catalinii commented 1 year ago

I do not remember why I did it that way, probably to mark the PMT pid for a pmt and to distinguish it from the actual streampids which are positive.

Jalle19 commented 1 year ago

Should we remove clean_psi if it's broken?

lars18th commented 1 year ago

Hi @Jalle19 ,

The clean_psi is now removed by @catalinii . Therefore, this PR continues having sense? Or you need to refactor it?

Jalle19 commented 1 year ago

I'll rebase and check

Jalle19 commented 1 year ago

Rebased

lars18th commented 1 year ago

Rebased

Hi @Jalle19 ,

This is not an old pull requests?

Jalle19 commented 1 year ago

No, two weeks is not two years

catalinii commented 1 year ago

Feel free to merge when ready