search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
324 stars 78 forks source link

Fix omitting unsubscribed PIDs from CA PMT, web interface tweaks #1071

Closed Jalle19 closed 1 year ago

Jalle19 commented 1 year ago

get_ca_multiple_pmt() was called on the stream adapter, not the CI adapter (introduced in https://github.com/catalinii/minisatip/pull/1026). Thus it would always return 0 and all PIDs would unconditionally be added to the DDCI PMT.

Furthermore, after fixing that bug, it turned out that the logic in CAPMT_add_PMT() was not necessary - the PMT given to the function will be the DD CI PMT and it will simply not contain any unwanted PIDs, so there's no filtering needed there.

I've updated the web interface to show PIDs for CI adapters too. There's still some improvements to be made there - currently it shows all PIDs, including excluded ones.

image

Jalle19 commented 1 year ago

Fixed the tests

Jalle19 commented 1 year ago

@Yuri666 can you test this branch for any regressions?

Jalle19 commented 1 year ago

Dropped the commits that added the null check and removed the CAPMT_add_PMT logic