Old packets left in DDCI buffer sometimes

[Jalle19]

Lately I've noticed that sometimes when I switch to a channel, the switch happens very quickly and K get about a second of old video/audio from the last time the channel was active. Could be a regression since introducing the new FIFO buffer? @catalinii have you noticed something similar?

[Jalle19]

It's of course also possible it's my tvheadend that is acting up.

[catalinii]

I think this is possible to happen:

• there is a latency between writing to DDCI device and reading
• FIFO (or the buffer before) was not cleaned of old data.

I did not pay attention and it probably can happen only if the old and new channel shares the same pids

[Jalle19]

I've only seen it when switching back to a channel that was previously tuned, i.e. you never get another channel's data, always stale data from the same channel.

Any way to fix this?

[Jalle19]

Gonna try reverting the FIFO changes locally to see if it helps. It seems to be easy to reproduce - just switch between a CAM channel and a free channel.

[Jalle19]

Reverting seems to fix the issue.

[catalinii]

Thx for the report

[catalinii]

Can you send me a quick repro?

[Jalle19]

Like I said, just switch between a CAM channel and a free channel. When you switch back to the encrypted channel it will start at the same place it started the last time.

[catalinii]

can you try next branch ? It should be fixed

[Jalle19]

Which commit is supposed to fix it? :thinking:

[catalinii]

Sorry forgot to push it.: https://github.com/catalinii/minisatip/commit/303ab856620e6676178efa538f4c7ad34be5dfb4

[Jalle19]

Thanks, I'll try to find time to test next week

[Yuri666]

For me it fixed

[Jalle19]

Seems fixed indeed, thanks @catalinii !