search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
324 stars 78 forks source link

UUID not generated if SSDP discovery is disabled #1078

Closed Jalle19 closed 2 months ago

Jalle19 commented 1 year ago

With discovery disabled, it should still be possible to use the SAT>IP server by providing the URL to /desc.xml manually. This currently only kind of works, because the XML is out of spec:

<UDN>uuid:</UDN>

This at least causes some older tvheadend versions to crash

lars18th commented 1 year ago

Interesting, so we need to generate the UUID outside of the SSD function.

Jalle19 commented 1 year ago

Yep, looks like it. I'm thinking it could also make sense to store the UUID in a file so it could be decoupled from the MAC address completely. But first step would be to separate it from SSDP discovery.

lars18th commented 1 year ago

Yep, looks like it. I'm thinking it could also make sense to store the UUID in a file so it could be decoupled from the MAC address completely. But first step would be to separate it from SSDP discovery.

I don't think so. Storing the UUID in a file will generate troubles. It's preferable to assign it with the command line if the user needs it. Remember it: minisatip is file config free !!

Jalle19 commented 1 year ago

I'm thinking it would auto-generate a random UUID and store it in a file if the file does not exist.

lars18th commented 1 year ago

Hi @Jalle19 ,

I implemented the fix in #1119 . 😉

lars18th commented 3 months ago

Hi @Jalle19 ,

Please remember to close this issue when PR #1140 will be merged. 👍

Regards.