catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
324 stars 78 forks source link

satipc module has a limit of 38 adapters #1132

Closed jyrts closed 4 months ago

jyrts commented 8 months ago
minisatip -R /root/minisatip/html -l general --logfile /tmp/minisatip.log --disable-dvb --disable-ssdp -A 0:0-7:0,1:8-15:0,2:16-23:0,3:24-31:0,4:32-39:0,5:40-47:0 \
-s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 -s 192.168.2.22 \
-s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 -s 192.168.2.20 \
-s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 -s 192.168.2.25 \
-s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 -s 192.168.2.24 \
-s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 -s 192.168.2.23 \
-s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 -s 192.168.2.32 \

minisatip.log

lars18th commented 7 months ago

Hi,

The bug is not "minisatip limited to 38 adapters". See the code: https://github.com/catalinii/minisatip/blob/80578a2031b14a63e3a2204be064134fda7fa1a8/src/adapter.h#L8

The problem is "satipc module has a limit of 38 adapters". Please, change the name of the issue.

lars18th commented 7 months ago

I suspect that this code is not receiving the "full list" of the servers pased by the command line: https://github.com/catalinii/minisatip/blob/80578a2031b14a63e3a2204be064134fda7fa1a8/src/satipc.c#L1658-L1660

Please @jyrts try to print the content of the satip_servers var in the LOG and execute with your command line.

Jalle19 commented 7 months ago

Good catch. I'll try to find some time to work on this, seems like a good opportunity to expand the test suite related to parameter parsing.

catalinii commented 6 months ago

this issue should be fixed now, can you test?