search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
332 stars 81 forks source link

Download the latest Coverity Scan client before performing the scan #1172

Closed Jalle19 closed 3 months ago

Jalle19 commented 3 months ago

Let's see if this works

Jalle19 commented 3 months ago

@catalinii can you double-check that there's a secret named COVERITY_SCAN_TOKEN?

catalinii commented 3 months ago

Yes COVERITY_SCAN_TOKEN exists

Jalle19 commented 3 months ago

@catalinii is it the same value as in your minisatip-build-image repository? I can't find a reason why the downloading of the client doesn't work

Jalle19 commented 3 months ago

@catalinii can you send me the token via e-mail or WhatsApp or soemthing so I can try this locally?

Jalle19 commented 3 months ago

Okay so the command works fine, but the token is not being read by GitHub for some reason

9000h commented 3 months ago

not sure but could this help

curl \
            --form token=$TOKEN \
Jalle19 commented 3 months ago

It simply doesn't work. @catalinii are you really sure the secret is defined in this project?

Jalle19 commented 3 months ago

It could be that it won't work for pull requests, otherwise anyone could make a PR that logs the token. We should try changing the action to only run against the master branch (makes more sense anyway) and merge this, then deal with the eventual fallout.

Jalle19 commented 3 months ago 

Coverity Build Capture (64-bit) version 2023.12.2 on Linux 6.5.0-1025-azure x86_64
Internal version numbers: 78329b8295 p-2023.12-push-50
make: *** No targets specified and no makefile found.  Stop.
Warning:  Build command make exited with code 2. Please verify that the build completed successfully.
Warning:  No files were emitted. This may be due to a problem with your configuration
or because no files were actually compiled by your build command.
Please make sure you have configured the compilers actually used in the compilation.
 For more details, please look at: 
    /home/runner/work/minisatip/minisatip/cov-int/build-log.txt
Error: Process completed with exit code 2.
Jalle19 commented 3 months ago

It passed! https://github.com/catalinii/minisatip/actions/runs/10573195509/job/29292218299