catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 81 forks source link

Auto QAM not allowed for DVB-C according to SAT>IP 1.2.2 specification #891

Closed ghost closed 3 years ago

ghost commented 3 years ago

you can try this not complete test for QAM_256 only

--- satipc.c.orig   2021-07-16 19:53:55.477965456 +0200
+++ satipc.c    2021-07-16 19:56:12.080336610 +0200
@@ -1105,6 +1105,10 @@
     satipc *sip = get_satip(ad->id);
     if (!sip)
         return;
+//quirk for Auroa client
+    if(tp->mtype == QAM_AUTO)
+        tp->mtype = QAM_256;
+
     url[0] = 0;
     FILL("freq=%.1f", tp->freq, 0, tp->freq / 1000.0);
     if (sip->use_fe && sip->satip_fe > 0)

@catalinii any idea how to workaround servers that do not handle QAM_AUTO like the AVM Fritzbox(the issue only happens when a client did not request 64qam or 256qam) the AVM did reply withe 408 for PLAY in this case

Originally posted by @9000h in https://github.com/catalinii/minisatip/issues/879#issuecomment-881620732

ghost commented 3 years ago

This quirk isn't embedded in the last commit. Can you please make a workaround for both 64qam and 256qam please? AUTO QAM isn't allowed in SAT>IP specifications, mtype is mandatory.

9000h commented 3 years ago

it's in but for 256qam only as @catalinii only agree to to it this way, but you can patch your private version easy https://github.com/catalinii/minisatip/blob/3ccdc47891db84eb863eeca7c738bec601cb64f0/src/satipc.c#L204-213

for 64qam it looks like

//quirk for Aurora client missing mtype 
    if(ad->tp.mtype == QAM_AUTO)
        ad->tp.mtype = QAM_256;
    else
        ad->tp.mtype = QAM_64;
9000h commented 3 years ago

It‘s only a workaround and at the moment there is no better solution in your case

ghost commented 3 years ago

Indeed, it doesn't work perfectly. I need QAM64 for the homing channel which scans for available muxes/channels. However, I need to try 3 or 4 times to finally get a stream for QAM64. The same goes after scanning channels. I have to try to start the stream several times. Most of the time it works when the adapter is reset after x seconds.

If this cannot be changed, please remove this 'Aurora fix' from commit as it doesn't help this way. Anyway thanks for your help so far.

I still find it interesting that my Panasonic TV hasn't this issue at all without missing mtype and works perfectly with scanning and streaming. That's why I opened this issue. However, I close it now. Maybe you can still fix it in the future.