search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
328 stars 81 forks source link

Various CI resource tweaks #942

Closed Jalle19 closed 2 years ago

Jalle19 commented 2 years ago

~Makes the Kabelio CAM in https://github.com/catalinii/minisatip/issues/910 initialize, although some issues still seem to remain.~

@Yuri666 what do you think?

Yuri666 commented 2 years ago

SAS support not unfinished. It sends fake host_id to CAM and end session. Without SAS support some CAMs don't work. I have such CAMs.

Yuri666 commented 2 years ago

btw, Kabelio CAM still not initialized properly with this changes

Jalle19 commented 2 years ago

Okay, I can drop that change. There was a comment in the source that says "this doesn't work, it's just for fun" 🤷

Yuri666 commented 2 years ago

hmm, really. sorry forgot to delete the comment

Jalle19 commented 2 years ago

Dropped the SAS commit, reworked the resource announcement to not include version 5 of Application Information.

Jalle19 commented 2 years ago

@Yuri666 what do you think about the remaining changeset? Works for me at least with a 1.4 CAM.

Yuri666 commented 2 years ago

You remove AI resource announcement, but also remove callback processing this resource. Maybe shall leave callback in code if in futures we'll needs to enable AI v.5, we can only add it at one line.

catalinii commented 2 years ago

Do you think this would work faster with remote access?

Jalle19 commented 2 years ago

@Yuri666 sure, I can leave the callback case values in place.

Jalle19 commented 2 years ago

@catalinii for https://github.com/catalinii/minisatip/issues/910, yes, probably

Jalle19 commented 2 years ago

@Yuri666 I added a commit with the changes you suggested (only announce latest version). Works for one of my CAMs at least, haven't tested the other one yet.

Yuri666 commented 2 years ago

Nice. I suggest also to remove this code, because it wrong: https://github.com/catalinii/minisatip/blob/master/src/ca.c#L75 https://github.com/catalinii/minisatip/blob/master/src/ca.c#L2849

Jalle19 commented 2 years ago

@Yuri666 done, good catch!

Jalle19 commented 2 years ago

@Yuri666 I had to re-add older host control and content control resources for my other CAM to initialize. Not sure what the best approach here is - clearly it's not possible to go by the recommendation in the spec.

Jalle19 commented 2 years ago

@Yuri666 FWIW I implemented the date time resource properly here: https://github.com/catalinii/minisatip/compare/master...Jalle19:datetime-test?expand=1

Can't say whether it makes any difference, but at least now the date is being sent to the CAM as often as the CAM wants :shrug: Will PR once we can sort out this resource mess.

Yuri666 commented 2 years ago

@Yuri666 I had to re-add older host control and content control resources for my other CAM to initialize. Not sure what the best approach here is - clearly it's not possible to go by the recommendation in the spec.

You sure what your CAM needs two versions both resources? Can you make log CAM initialization with -l ca option?

Yuri666 commented 2 years ago

@Yuri666 FWIW I implemented the date time resource properly here: https://github.com/catalinii/minisatip/compare/master...Jalle19:datetime-test?expand=1

Can't say whether it makes any difference, but at least now the date is being sent to the CAM as often as the CAM wants 🤷 Will PR once we can sort out this resource mess.

I made same alredy in test branch in my repository. No filling any difference with my CAMs. It doesn't really matter because CAM takes time from the stream

Jalle19 commented 2 years ago

@Yuri666 I had to re-add older host control and content control resources for my other CAM to initialize. Not sure what the best approach here is - clearly it's not possible to go by the recommendation in the spec.

You sure what your CAM needs two versions both resources? Can you make log CAM initialization with -l ca option?

Yeah, if I comment out the older host control and/or content control versions it gets stuck when the CAM is supposed to start the content control stuff.

I'll see if I can get a log.

Yuri666 commented 2 years ago

Yeah, if I comment out the older host control and/or content control versions it gets stuck when the CAM is supposed to start the content control stuff.

please try to leave only CIPLUS_APP_DVB_RESOURCEID of dvb control and all as is of content control - is it will work?

Jalle19 commented 2 years ago

We should try https://github.com/OpenViX/enigma2/blob/58c05ef12d11a98a698c368ae2bde4664b550b8b/lib/dvb_ci/dvbci_resmgr.cpp#L82 since everyone seems to say their stuff works on Enigma 🤷

Jalle19 commented 2 years ago

We should try https://github.com/OpenViX/enigma2/blob/58c05ef12d11a98a698c368ae2bde4664b550b8b/lib/dvb_ci/dvbci_resmgr.cpp#L82 since everyone seems to say their stuff works on Enigma shrug

Tried it, got "Your host is not fully CI plus compliant" from the CAM :shrug:

Jalle19 commented 2 years ago

I dropped the "use the highest version of each resource only" commit since it didn't seem to actually work. Also re-added the handling of AI resource version 5 so it's only a matter of announcing it if we want to try to support it.

Jalle19 commented 2 years ago

Been using this for a long time locally with my two CAMs, everything seems to work smoothly. I've got other fixes lined up that are based on this branch so I will go ahead and merge this and PR the next batch.

If there are any issues with these please let me know so we can keep master working for everyone!