search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
328 stars 81 forks source link

Reset decoding errors when starting to decode #954

Closed lars18th closed 2 years ago

lars18th commented 2 years ago

When a new program is started to decode, at first some packets can't be decoded. This could be annoying when viewing the UI as you can interpret that some decoding errors have appeared. But this is not the case. Futhermore, if after the initial decoding some packets can't be decoded you need to remember the initial count to know the real non-decoded packets.

This patch adds a new behaviour: When first starting to receive a new program, the counter of non-decoded packets will continue to work as now. Therefore, if the program cannot be decoded, the counter can be viewed incrementing. But when the program starts to be decoded, then the counters are reset. So only if new decoding errors appear after the initial decoding you will see this counter in the UI.

This new behaviour is more consistent and user friendly.

Jalle19 commented 2 years ago

Nice, I've been wondering why the UI says there are hundreds/thousands of DEC-ERRORS that then tend to remain constant.

catalinii commented 2 years ago

@Jalle19 is not the case for this PR, but in general please check https://github.com/catalinii/minisatip/issues/841 to ensure there are no coverity issues (only when merging PRs).

Jalle19 commented 2 years ago

@catalinii thanks, I'll try to remember!