catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 80 forks source link

Incorrect URL mentioned on status page #966

Closed ghost closed 1 year ago

ghost commented 2 years ago

The RTSP and HTTP links are mentioned on the status page of minisatip on port 8080. However, the URL's are incorrect for DVB-C.

the following parameters aren't allowed for DVB-C:

For example how it should look like: http://192.168.0.10:8080/?freq=378&msys=dvbc&sr=6900&mtype=256qam&pids=0,16,17,18,20,2300,2301,2401,2311

With RTSP link also @ is mentioned and with HTTP link http in address is missing at the beginng of the url.

capture rtsp link

capture http link

Jalle19 commented 2 years ago

Where does it say that fe, src and pol are invalid for DVB-C?

ghost commented 2 years ago

Hi, it can be found in the SAT>IP protocol. See query example for DVB-C as well. And fe, src and pol aren't mentioned for DVB-C. Those are for DVB-S.

image

Jalle19 commented 2 years ago

This is a bug in status.html, it should be smarter about adding parameters to the URL.

catalinii commented 2 years ago

fe cannot be removed as it selects which DVB C/T adapter is being used. The other 2 (src, pol) were removed in this PR. cc @Jalle19

Jalle19 commented 2 years ago

Looks good, at some point we should refactor and clean up some of this logic.

ghost commented 2 years ago

Great, thanks! If Netstream 4C SAT>IP device is used, fe isn't allowed. It would be nice if the URL in this case also doesn't show fe parameter.

patacalas commented 2 years ago

"isi" and "plsc" params are missing on multistream HTTP and RTSP links.

image

In addition, alternative audio pids are missing too. URL link only shows the selected audio on Sat-IP client which is playing the channel.

catalinii commented 1 year ago

@retrofan1979 are you talking about the request to the satip server Netstream 4C SAT>IP not involving the URL from minisatip web page ? Or you are talking about copying the URL from web and then sending it to netstream?

ghost commented 1 year ago

@catalinii yes, the real executed URL isn't displayed on the webpage of minisatip. In case of the Netstream 4C the fe parameter isn't allowed as the device does control itself.

catalinii commented 1 year ago

@retrofan1979 not sure I got the answer to my questions. 1) Is the issue with the satip client module in minisatip making the request to Netstream 4C ? [Yes/No] 2) The URL from the web page includes fe= (as is the case now) causing issues with Netstream 4C ? [Yes/No]. 3) Related to the URL executed is not displayed on minisatip page, what is missing ? Please test https://github.com/catalinii/minisatip/tree/issue_966

ghost commented 1 year ago

Is the issue with the satip client module in minisatip making the request to Netstream 4C ? [Yes/No] NO The URL from the web page includes fe= (as is the case now) causing issues with Netstream 4C ? [Yes/No]. NO Related to the URL executed is not displayed on minisatip page, what is missing ? Nothing is missing, but the Netstream 4C doesn't support the frontend (fe) parameter, so I expect this parameter will not be displayed at the minisatip page. The same goes for pol and src parameters which are not supported for DVB-C, so in my opinion it may not be displayed in the URL.

catalinii commented 1 year ago

Can you check how is it now with the latest master?

9000h commented 1 year ago

looks like the channel names get mixed up when you have multiple delsys like dvbs and dvbc It will crash also with signal 11 after some channel switches between different delsys

catalinii commented 1 year ago

can you upload the logs? (make debug) also can you provide more info for the "channel names getting mixed up" ?

9000h commented 1 year ago

here is a sample showing the same channel name for dvb-s and dvb-c which is wrong Unbenannt

9000h commented 1 year ago

probably releated to #1000

catalinii commented 1 year ago

Channel names are fixed

Jalle19 commented 1 year ago

Can this be closed?

lars18th commented 1 year ago

Can this be closed?

I feel it can be closed. Someone with a DVB-C tuner can check it, please?