search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 80 forks source link

Send diseqc command with 18V #968

Closed lars18th closed 1 year ago

lars18th commented 2 years ago

When multiple tuners share the same wire in a master-slave configuration, it's preferable to send all diseqc commands using the 18V voltage. Then commands are more easy to read from devices when tuners inject incorrect power or slave tuners are miss configured. This behaviour increase the robustness of the diseqc commands.

lars18th commented 2 years ago

Hi @catalinii and @perexg ,

Please check it. This improves the switching in my house using multiple tuners connected to the same wire.

Regards.

lars18th commented 2 years ago

Hi,

No comments? Take note that the CI error it's caused by an internal error of the service. The code is clean. In my environment this change has reduced the tunning errors caused by switches to near zero. And the original idea is not mine.

Regards.

lars18th commented 2 years ago

Hi,

No one tested this patch ❓ 😮

Jalle19 commented 2 years ago

More master-slave hacks :shrug:

lars18th commented 2 years ago

More master-slave hacks 🤷

Not really. After reviewing the code of some boxes and servers, I've noticed that some of them send all diseqc commands using 18V signals. This solves some troubles with multiple switches in cascade, and when multiple tuners are connected with the same wire. It seems it's a common practice. And after incorporating this in my minisatip servers the switch selection never fails, even using more than one box connected to the same coax. So as it doesn't have any side effect (almost any that I've detected) I suggest to merge it.

You agree?

Jalle19 commented 2 years ago

It's fine by me, although I'm not able to test it

catalinii commented 2 years ago

More master-slave hacks 🤷

Not really. After reviewing the code of some boxes and servers, I've noticed that some of them send all diseqc commands using 18V signals. This solves some troubles with multiple switches in cascade, and when multiple tuners are connected with the same wire. It seems it's a common practice. And after incorporating this in my minisatip servers the switch selection never fails, even using more than one box connected to the same coax. So as it doesn't have any side effect (almost any that I've detected) I suggest to merge it.

Can you post which other servers do this?

Jalle19 commented 1 year ago

Let's close these old pull requests, they can be re-opened if necessary.