search

catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 80 forks source link

CI build fails #974

Closed lars18th closed 2 years ago

lars18th commented 2 years ago

Please fix this error with the CI build:

Run wget -q https://scan.coverity.com/download/cxx/linux64 --post-data "token=$TOKEN&project=$PROJECT" -O cov-analysis-linux64.tar.gz
  wget -q https://scan.coverity.com/download/cxx/linux64 --post-data "token=$TOKEN&project=$PROJECT" -O cov-analysis-linux64.tar.gz
  mkdir cov-analysis-linux64
  tar xzf cov-analysis-linux64.tar.gz --strip [1](https://github.com/catalinii/minisatip/runs/6688521382?check_suite_focus=true#step:7:1) -C cov-analysis-linux64
  shell: /usr/bin/bash -e {0}
  env:
    TOKEN: 
    PROJECT: minisatip[2](https://github.com/catalinii/minisatip/runs/6688521382?check_suite_focus=true#step:7:2)
Error: Process completed with exit code [6](https://github.com/catalinii/minisatip/runs/6688521382?check_suite_focus=true#step:7:6).
Jalle19 commented 2 years ago

I think only @catalinii can fix this since the tokens aren't visible to non-owners in Coverity nor in GitHub

catalinii commented 2 years ago

@lars18th where do u see this?

Jalle19 commented 2 years ago

https://github.com/catalinii/minisatip/runs/6688521382?check_suite_focus=true

catalinii commented 2 years ago

I think the only option is to hardcode the token.

Jalle19 commented 2 years ago

I'm don't think that's a good idea. Does the wget work locally when you supply the token?

catalinii commented 2 years ago

Yeah it does. The only other option is to bake the binary in minisatip-build-image and there I can use the token. But then will need to update the (docker) image regularly which probably is an acceptable compromise.

Jalle19 commented 2 years ago

Surely there must be a way to specify secret environment variables in GitHub Actions? 🤔

Jalle19 commented 2 years ago

@catalinii could we consider hosting a copy of the Coverity ZIP file on minisatip.org?

catalinii commented 2 years ago

Yeah we can do that too...the issue is updating it often enough that's why I proposed to bake it in minisatip build image. A new PR in minisatip-build-image will always fetch the latest version

catalinii commented 2 years ago

Whatever you prefer I am fine with both

Jalle19 commented 2 years ago

I'm fine with any solution really 🤷

catalinii commented 2 years ago

I changed the minisatip-build-image and just involed coverity in PRs and it works.