catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 80 forks source link

Auto QAM: set qam parameter if it's not specified by client #988

Closed ghost closed 2 years ago

ghost commented 2 years ago

Can you please also let minisatip set qam parameter if it's not specified by client? Normally it's qam256 at default, but sometimes it's qam64.

Jalle19 commented 2 years ago

@retrofan1979 what's the use case for this? AFAICT the client should always specify mtype?

ghost commented 2 years ago

Yes, you're right, but I'm using an old client which I like very much, but it's not maintained anymore, so I was hoping minisatip can fix this. By the way, my Panasonic TV works correctly with this app, so indeed because it's non-spec, the Panasonic does correct it as it should. Maybe minisatip can do the same.

If not, please guide me which changes I have to make, so I can compile a private build ;-) Thanks!

Jalle19 commented 2 years ago

The default value should be QAM_AUTO, do you have a tuner which doesn't support that?

Jalle19 commented 2 years ago

You can change the default in init_dvb_parameters in dvb.c if you want to test

ghost commented 2 years ago

Okay, thanks. I have the Elgato Netstream 4C.

ghost commented 2 years ago

Maybe you can put the needed code here? That would be nice!

ghost commented 2 years ago

I also tried the Fritz!WLAN Repeater DVB-C and Fritz!Box 6660 Cable and they have the same behaviour as the Elgato Netstream 4C. Only my Panasonic TV with build-in SAT>IP server is capable to fix it by adding the correct qam parameter if the client doesn't supply it. Would be nice if minisatip can do the same as my Panasonic TV.

Jalle19 commented 2 years ago

Do you know which QAM your TV adds? 64, 128, 256?

ghost commented 2 years ago

Yes, both 64 and 256. For scanning channels my cable operator uses qam64 and for watching channels qam256. https://dvblogic.com/wiki/index.php/Fast_channel_search_parameters

9000h commented 2 years ago

https://github.com/catalinii/minisatip/issues/879#issuecomment-881907436

Jalle19 commented 2 years ago

So this is an issue specifically when using minisatip client mode (satipc) with a server that doesn't support QAM_AUTO? I'm confused. Could it just be that the Panasonic TV handles QAM_AUTO correctly as it should?

Jalle19 commented 2 years ago

@retrofan1979 ?

ghost commented 2 years ago

Yes, with Panasonic TV as SAT>IP server, I have no problems with this old client (Android app). Probably the Panasonic TV adds this parameter when the client doesn't request it and tries different modulations like 64 and 256. The other mentioned SAT>IP servers don't do this, but I think the way of how Panasonic implemented it is correct, as this parameter is mandatory according to the SAT>IP protocol, so it will be corrected by the server. I agree the client should do a correct request, but for compatibility this is a nice approch of Panasonic.

Jalle19 commented 2 years ago

I'm not sure it's feasible to implement this. QAM can vary per mux, so there may not be a default value that works for all channels.

Jalle19 commented 2 years ago

I'm closing this for now, until we maybe come up with a good enough workaround.