catalinii / minisatip

minisatip is an SATIP server for linux using local DVB-S2, DVB-C, DVB-T or ATSC cards
https://minisatip.org
327 stars 80 forks source link

Expose command line and CAM information to web interface #999

Closed Jalle19 closed 1 year ago

Jalle19 commented 1 year ago

This PR consists of four distinct parts:

I haven't been able to runtime test the CA changes yet, only modified the state locally in the web interface to emulate a CI device.

Screenshots: Screenshot-20221007105639-248x127 Screenshot-20221007104212-681x147

When compile testing this on a different computer (with GCC 10 instead of GCC 9) I noticed that the GCC 10 complains about multiple definitions of variables by default (https://gcc.gnu.org/gcc-10/porting_to.html), so I figured I'd add the -fno-common option to Makefile.

Closes #981, closes #982

Jalle19 commented 1 year ago

AFAICT I fixed Coverity CID 400978.

Jalle19 commented 1 year ago

@catalinii ready for review

Jalle19 commented 1 year ago

Added tests for get_command_line_string

Jalle19 commented 1 year ago

Still need to find some time to test this before merging.

Jalle19 commented 1 year ago

@pannlala found some use for your reader after all!

@catalinii turns out the logic that saved which CAIDs each CAM supports was broken. It's fixed in the latest commit.

Normal operation (no -c parameter): Screenshot-20221007221613-549x194

Using -c to limit the list of supported CAIDs (-c 1:1-0100-0500): Screenshot-20221007221649-297x167

catalinii commented 1 year ago

Please squash the commit that is merged when merging for the history to be cleaner.

Jalle19 commented 1 year ago

Will do next time!