search

catalogicsoftware / ngx-dynamic-dashboard-framework

This is a JSON driven angular x based dashboard framework that is inspired by JIRA's dashboard implementation and https://github.com/raulgomis/angular-dashboard-framework
MIT License
187 stars 95 forks source link

Interested in Collaboration and PR's #4

Open meikeric opened 6 years ago

meikeric commented 6 years ago

I've forked your repo and have made quite a bit of changes to support our needs. Are you interested in collaborating and seeing if any of these changes would be advantageous to your project?

pietromarrone commented 6 years ago

Where is you report, maybe we can be interested in.

jayhamilton commented 6 years ago

@meikeric Good to see that you are taking up this project. Yes I would be interested in see if your changes will help us.

meikeric commented 6 years ago

@jayhamilton and @pietromarrone Check out: https://github.com/AngularDashboardFramework/AngularDashboardFramework

Jay, I've taken your last commit and refactored it into an Angular Library so that in the future a user will be able to npm install ... and then <adf-board [model]="model"> and away they go.

I moved the angular-cli specific stuff into /example and left the core code in /src.

Right now I'm battling some AOT compilations issues, but figures crossed I'll get them fixed shortly.

Next steps are to re-integrate all my previous changes: Renamed gadgets -> widgets Made your gadgets naming more generic, e.g. Horizontal Bar Chart, etc... Changing the Gadget Registry to support self registration so users can create their own widgets outside of this project. Configurations are rendered in Modals instead of in the gadget area. Separated Gadget's into distinct modules. Gadgets Configurations models are contained within Gadgets themselves instead a master object. Gadget configurations can be custom rendered by the gadget module is a gadget config is extremely complex. Changes to rendering. Themeable so it's not dependent on Semantic-UI, Material, etc. There's a ton of changes, but you should see the repo getting updated over the next few days as this is something I've needed to take care of.

pietromarrone commented 6 years ago

@meikeric Great job and good action plan. My fault was the renaming of Md Material stuff into Mat, just today I renamed files, but now I saw you did it too. I'll follow https://github.com/AngularDashboardFramework/AngularDashboardFramework and I'll try to contribute

jayhamilton commented 6 years ago

Guys, looks like this is heading in a good direction. I appreciate all of the contributions and will take a look at the changes.

Thanks!

jayhamilton commented 6 years ago

@meikeric I began reviewing some of your changes. They look good.

meikeric commented 6 years ago

Thanks @jayhamilton, I haven’t had a stretch of time to get my component factory changes integrated. I’ll try this week. And then my final contribution will be splitting Widgets/gadgets into separate a separate library.