search

catalogueglobal / datatools-ui

Core application for the Conveyal transit data tools suite. NOTE: Active development has returned to https://github.com/conveyal/datatools-ui
MIT License
23 stars 8 forks source link

Merge dev to master #251

Closed evansiroky closed 5 years ago

evansiroky commented 5 years ago

It's time to bite the bullet and merge dev to master.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b4163e2). Click here to learn what that means. The diff coverage is 4.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #251   +/-   ##
========================================
  Coverage          ?   5.23%           
========================================
  Files             ?     324           
  Lines             ?   15405           
  Branches          ?    4649           
========================================
  Hits              ?     806           
  Misses            ?   12449           
  Partials          ?    2150
Impacted Files Coverage Δ
lib/gtfs/reducers/validation.js 20% <ø> (ø)
lib/gtfs/components/gtfs-search.js 0% <ø> (ø)
lib/gtfsplus/selectors/index.js 0% <ø> (ø)
lib/gtfsplus/components/GtfsPlusField.js 0% <ø> (ø)
lib/editor/containers/ActiveTripPatternList.js 0% <ø> (ø)
lib/gtfs/containers/GlobalGtfsFilter.js 0% <ø> (ø)
lib/manager/components/FeedSourceSettings.js 0% <ø> (ø)
lib/editor/reducers/mapState.js 40% <ø> (ø)
lib/editor/components/HourMinuteInput.js 0% <ø> (ø)
lib/editor/components/map/StopsLayer.js 0% <ø> (ø)
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4163e2...79d8bbe. Read the comment docs.

landonreed commented 5 years ago

@evansiroky, I think for these release PRs we could probably follow the convention that appears to have emerged for other projects and just name it after the release version (which I think you can come up with by running semantic-release locally). Could you update the PR with this info?

Also, I don't know if we have formally established this, but it might be a good idea to run the end-to-end test for a release and indicate with which version of the datatools-server repo it passed.

evansiroky commented 5 years ago

Closing in favor of https://github.com/conveyal/datatools-ui/issues/360