search

catalyst-cooperative / pudl-catalog

An Intake catalog for distributing open energy system data liberated by Catalyst Cooperative.
https://catalyst.coop/pudl/
MIT License
9 stars 2 forks source link

Add s3 bucket support #70

Closed bendnorman closed 1 year ago

bendnorman commented 1 year ago

This PR adds the new s3://intake.catalyst.coop bucket and sets it as the default. I also removed the requester pays documentation, given we don't want users to be using the GCS requester pays bucket.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.0% // Head: 100.0% // No change to project coverage :thumbsup:

Coverage data is based on head (d027d82) compared to base (7915cb4). Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #70 +/- ## ======================================= Coverage 100.0% 100.0% ======================================= Files 2 2 Lines 44 44 ======================================= Hits 44 44 ``` | [Impacted Files](https://codecov.io/gh/catalyst-cooperative/pudl-catalog/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative) | Coverage Δ | | |---|---|---| | [src/pudl\_catalog/\_\_init\_\_.py](https://codecov.io/gh/catalyst-cooperative/pudl-catalog/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative#diff-c3JjL3B1ZGxfY2F0YWxvZy9fX2luaXRfXy5weQ==) | `100.0% <100.0%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

zaneselvans commented 1 year ago

I think the failing tests here are because we were using an old version of the EPA CEMS outputs previously, which had a few additional columns that have since been removed by @aesharpe, so I am updating the expectations in the integration tests now.

zaneselvans commented 1 year ago

Oh thank goodness nobody will have to authenticate. That was gonna be annoying.

bendnorman commented 1 year ago

If the CI passes this PR should be good to go @zaneselvans