catalyst-cooperative / pudl-catalog

An Intake catalog for distributing open energy system data liberated by Catalyst Cooperative.
https://catalyst.coop/pudl/
MIT License
9 stars 2 forks source link

Merge GCP skipping logic into main #87

Closed bendnorman closed 1 year ago

bendnorman commented 1 year ago

Turns out the logic for skipping the GCS tests was never merged into main.

Dazhong created a branch off of main so the CI made a bunch of requests to the intake.catalyst.coop bucket which resulted in a hefty egress fee.

This PR just merged the changes from dev into main.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.0% // Head: 100.0% // No change to project coverage :thumbsup:

Coverage data is based on head (ff28ac8) compared to base (965eaf7). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ======================================= Coverage 100.0% 100.0% ======================================= Files 2 2 Lines 44 44 ======================================= Hits 44 44 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalyst-cooperative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bendnorman commented 1 year ago

Have you run into this readthedocs failure before @zaneselvans?

bendnorman commented 1 year ago

The RTD build was failing because the UnionType was not available in the beta version of python 3.10 RTD was using. Turns out the python.version config option has been deprecated in favor of build.tools.python. To use the new option you also need to specify the build.os which has replaced build.image. These changes have been made in the Cheshire repo.

zaneselvans commented 1 year ago

Ah, yeah sorry. I think I did just fix this in the main pudl repo. We should propagate it everywhere.