search

catalyst-cooperative / pudl-usage-metrics

A dagster ETL for collecting and cleaning PUDL usage metrics.
MIT License
1 stars 0 forks source link

Use WIF for tox-pytest and load-metrics workflows #102

Closed jdangerx closed 1 year ago

jdangerx commented 1 year ago

This should move us one step closer to not needing credentials jsons floating around, and maybe even lets us merge bot PRs automatically.

tox-pytest has some continue-on-error stuff in the hopes that that alleviates issues with external PRs, but load-metrics will only be run internally so I'm not concerned about that.

jdangerx commented 1 year ago

The CI is failing with some BigQuery errors, are we sure we're not supposed to authenticating as pudl-logging@catalyst.coop or pudl-usage-metrics-etl@catalyst.coop ? cc @bendnorman

bendnorman commented 1 year ago

My bad. We should be authenticating with the pudl-usage-metrics-etl@catalyst-cooperative-pudl.iam.gserviceaccount.com account. This is what I get for creating an unhelpful secret name :/

zaneselvans commented 1 year ago

@jdangerx Hey I don't know if I'm actually a great reviewer for this since I haven't really maintained this repo, and don't really understand WIF...

jdangerx commented 1 year ago

I think it was just the @catalyst-cooperative/inframundo round-robin thing. I just requested review from @bendnorman but also if you want to talk about WIF etc. I'm happy to bring you up to speed!

zaneselvans commented 1 year ago

I think we should have a little WIF show-and-tell at some point once we feel like it's covering our bases so more of us understand how to work with it.