catalyst-cooperative / pudl-usage-metrics

A dagster ETL for collecting and cleaning PUDL usage metrics.

MIT License

1 stars 0 forks source link

Drop NAs from IPs before geocoding #212

Closed e-belfer closed 3 weeks ago

e-belfer commented 3 weeks ago

Overview

What problem does this address? Fixes the build failure here: https://github.com/catalyst-cooperative/pudl-usage-metrics/actions/runs/11549171533

What did you change in this PR?

I can't reproduce this error locally, but we shouldn't be trying to geocode NA values anyways, so we may as well dropna() before geocoding IPs.

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

- [x] Review the PR yourself and call out any questions or issues you have