move EIA plant-part validation test (or remove them?)

catalyst-cooperative / pudl

The Public Utility Data Liberation Project provides analysis-ready energy system data to climate advocates, researchers, policymakers, and journalists.

https://catalyst.coop/pudl

MIT License

456 stars 106 forks source link

move EIA plant-part validation test (or remove them?) #1617

Open cmgosnell opened 2 years ago

cmgosnell commented 2 years ago

these two lines:

self.validate_ownership_for_owned_records(self.plant_parts_eia)
validate_run_aggregations(self.plant_parts_eia, gens_mega)

take a whiiiile to run bc they are effectively re-running the aggregations.... imo we should either:

move them from these defensive tests to actual validation tests
or remove them?!?

katie-lamb commented 2 years ago

+1 to this. I haven't really dug into what they do but they should probably end up in validation tests? This refactor could happen if/when the AddConsistentAttribute class is sped up.