catalyst-cooperative / pudl

The Public Utility Data Liberation Project provides analysis-ready energy system data to climate advocates, researchers, policymakers, and journalists.
https://catalyst.coop/pudl
MIT License
468 stars 107 forks source link

Outputs failing w/o FERC bc of datetime issues #236

Closed cmgosnell closed 1 year ago

cmgosnell commented 5 years ago

Not exactly sure what is happening here, but when you have a db initialized with only EIA, the outputs for EIA break. I was attempting to look at the MCOE output using the PudlTabl object, but the same issue was cropping up when using most of the PudlTabl functions.

Each PudlTabl function that involves EIA only tables but requires either the puld.helpers.merge_on_date_year() or any other report_date merge was giving me errors like AssertionError: Zero dates found! or ValueError: You are trying to merge on datetime64[ns] and float64 columns. If you wish to proceed you should use pd.concat.

All of this stopped when I re-initalized including even just one FERC year, although I'm not sure why,

zaneselvans commented 1 year ago

With all the changes we've made to how datetime aggregation/merges happen in the PUDL outputs, I think this is no longer an issue.