Closed zaneselvans closed 1 year ago
utility_type
.balance
column still have meaning with all of the mucking around we've done in the calculations?subdimension
column mean? What values are allowed in it?electric
values found in the plant_function
column, but I don't think that's a valid value, based on the enumerated values in pudl.transform.ferc1.params.PLANT_FUNCTION_CATEGORIES
source_tables
lists? Which column were they exploded into?utility_type
and plant_status
show up in the balance sheet assets explosion, but not in the liabilities explosion. Does that matter? They seem kind of analogous to each other.ferc_account
for instance. Right now both tables (the factoid-level and calc-component-level tables) are very overlapping. I did this semi-intentionally bc I wasn't sure where we would need which piece of info. I think we should sort that out through the implementation of this issue.I'm struggling with the new calculation_components_xbrl_ferc1
association table. The MetadataExploder.calculations()
method needed to be updated to appropriately manage calculations that refer to components from outside of the explosion (turning them into parent-only calculation components) but either the inputs don't look like I think they do, or I'm doing something wrong in the new method, or my expectations about what should be true about the dataframe that's coming out of the method are wrong. See #2763
With #2721 merged, the additional dimensions
utility_type
,plant_status
, andplant_function
are available in the newly compiled tabular calculation components table and in the exploded dataframes.In order to validate and debug the calculations that involve these dimensions, and use them in analysis of the exploded data, they need to be integrated into the calculation forests, and the leaf-based filtering of the exploded data.
Rather than identifying a calculation component by (
table_name
,xbrl_factoid
) we'll now need to use a tuple that also includes all of the other dimension columns. In many cases these will include null values, since not all dimensions are involved in all calculations. This larger tuple will also be used to filter the final exploded data table.