catalyst-cooperative / pudl

The Public Utility Data Liberation Project provides analysis-ready energy system data to climate advocates, researchers, policymakers, and journalists.
https://catalyst.coop/pudl
MIT License
476 stars 109 forks source link

Clean up exploded assets and rate base tags #2892

Closed e-belfer closed 10 months ago

e-belfer commented 1 year ago

Based on a first round of feedback, let's address some outstanding issues with the exploded assets and rate tags.

2894:

2916

2918

Still to do:

Out of scope

e-belfer commented 1 year ago

The four missing calcs can be explained by DBF-only factoids used up through 2003, which were later replaced by multiple more detailed factoids. See #2700 for more detail.

cmgosnell commented 1 year ago

hey @jrea-rmi ! one hopefully simple question... for the utility_plant_summary_ferc1 labeling of the plant_status-es, they should be labeled within the headers that are in the taxonomy/form itself? As in the field labeled "Leased to Others" in the "In Service" section should be labeled in_service not leased, right?

update!

i was looking at the taxonomy incorrectly! the "Leased to Others" is not nested under "In Service" so I think it is more clear than I originally thought. But secondary question: how should construction work in progress be labeled?/ how do you want these guys to be labeled:

image

I'm assuming utility_plant_net & accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility should be "plant_status"=="total" bc they are the big sums.

cmgosnell commented 1 year ago

also i was a little too hopelessly optimistic yesterday about adding the `plant_status's into the core db tables when they are not a part of the natural pk! The sticking point here is that when we check the calculations, we use the dimension columns as merge keys, which effectively means dimensions on the parent and child side of a calculation need to be either the same value or be null. (i believe!)

which means we add em as tags!

jrea-rmi commented 1 year ago

phew, I was confused by "Leased to Others" within "In Service." Generally, the plant_status coming from this table has been maybe the most confusing thing to me in all of FERC data.

I think utility_plant_net = utility_plant_and_construction_work_in_progress - accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility. And that it'd make sense for all of those to be labeled as "plant_status"=="total".

I think construction_work_in_progress should get the same plant_status label of construction_work_in_progress. Do you have any alternative ideas?

e-belfer commented 1 year ago

I think construction_work_in_progress should get the same plant_status label of construction_work_in_progress. Do you have any alternative ideas?

Assuming you mean utility_plant_and_construction_work_in_progress and construction_work_in_progress should both get the same label? I agree. The other total labellings suggested all make sense to me @jrea-rmi and I can update them.

jrea-rmi commented 1 year ago

I think construction_work_in_progress should get the same plant_status label of construction_work_in_progress. Do you have any alternative ideas?

Assuming you mean utility_plant_and_construction_work_in_progress and construction_work_in_progress should both get the same label? I agree. The other total labellings suggested all make sense to me @jrea-rmi and I can update them.

I'm thinking utility_plant_and_construction_work_in_progress with plant_status=="total" and construction_work_in_progress with plant_status=="construction_work_in_progress"

cmgosnell commented 10 months ago

I think this one is fully closable but @e-belfer if you have an objections to that plz just reopen