Open zaneselvans opened 2 months ago
ty for catching the non-working partitions in the full settings! I'm also confused why the validations didn't fail for me locally. after changing the working partitions in sources i was able to re-run the full extraction and only get the working years. that's weird for sure.
A lot of the magic is happening via extract.extractor.raw_df_factory
which runs extract.extractor.partition_extractor_factory
which uses the datastore and the dataset_settings. I was mirroring the eia 176 extract which required those two as inputs into the asset but doesn't pass them around - but instead accesses them within raw_df_factory
.
I agree in general that the extractor setup needs some documentation cleanup and maybe some higher level explanation somewhere.
Tangible outcome here is:
should have failed on import but that wasn't happening.
@e-belfer might deal with this incidentally as part of integrating the new ATB.
Overview
etl_full.yml
settings for the NREL ATB included the years 2019 and 2020, which aren't yet working (See #3576) and Pydantic's validation of the settings correctly failed. I went ahead and removed those years from the settings file onmain
so we can get another attempted build tonight.raw_nrelatb__data
asset claims to require thedatastore
anddataset_settings
resources, but doesn't actually make use of them.Extractor
claims to require aDatastore
as input, but doesn't receive one.