search

catalyst-cooperative / rmi-ferc1-eia

A collaboration with RMI to integrate FERC Form 1 and EIA CapEx and OpEx reporting
MIT License
3 stars 3 forks source link

add the plant name as a model parameter #32

Closed cmgosnell closed 4 years ago

cmgosnell commented 4 years ago

I've be slightly reticent to do this because the FERC strings are generally unreliable and we are going to have to generate a plant name from EIA that is a composite string and deciding what goes into that string seems slight complicated. In culling false granularities, we've made a decision to hierarchically choose the "right" record to keep. For unit records (which we prioritize over prime movers), we could add in the unit id, but that could be the same granularity as the PM and the PM code could be in the ferc name.

One option would be to just use the assigned plant part to generate a composite name. Another would be to generate a composite name that included all elements from the set of records that are the same granularity. In our unit/PM example above, that result in something like "burny mc burn unit 2A ST". The complexity here is building the ability to know the full group of similar granularities - not impossible but this is currently not built into the system.

cmgosnell commented 4 years ago

I went with the simplest option here - to add in the name based on the "true" part. This is not perfect. If a unit is labeled as a the true part, than we are using the unit id not the generator id that is a part of that unit. We might want to revisit this later, but for now, I will close this issue.