Update packages and Python version for repo

catalyst-cooperative / rmi-ferc1-eia

A collaboration with RMI to integrate FERC Form 1 and EIA CapEx and OpEx reporting

MIT License

3 stars 3 forks source link

Update packages and Python version for repo #334

Closed e-belfer closed 1 year ago

e-belfer commented 1 year ago

It's time to update this repo so it works again. Updates include:

deprecating setup.py and moving to pyproject.toml
updating packages
updating to Python 3.11
adding some additional tests into the CLI to more closely mirror PUDL (with the exception of bandit and mypy which would require additional code retooling to pass currently)
updating all references to the record linkage CSVs to point to PUDL, where they now live

zaneselvans commented 1 year ago

Looks like it's getting to the point of running the integration tests but then erroring out, rather than having a test failure.

e-belfer commented 1 year ago

This failure occurs for 2 reasons: 1) We need to update the CSVs in the repo to reflect their migration to the PUDL repo. The ones in here are now out of date and failing the validation tests. 2) Something in the CI isn't correctly pointing to the new PUDL engine. Some of these failures only occur on CI, and not locally.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

e-belfer commented 1 year ago

This now passes locally. There is still an error in how the CI is configuring, as the errors indicate an issue with reading from PUDL DB.