search

catalyst-offgrid / catalyst-aip

Catalyst Access Insights Platform (AIP)
https://accessinsights.org/
MIT License
2 stars 4 forks source link

Add data sources and layers to map #1

Closed AliceR closed 4 years ago

AliceR commented 4 years ago

This change adds the provided Mapbox Tilesets as layers to the map with some basic styling.

The source and layer definitions are read from config files, and added to the map based on these lists. This is an effort to account for scaling, making the future addition of new layers as simple as possible.

Plus: Added a Github Action to run lint and test on Pull Requests. I am curious if it works :)

jvntf commented 4 years ago

@AliceR looking great! whats the advantage of parcel over webpack?

AliceR commented 4 years ago

@jvntf as for parcel over webpack... I guess there is no real advantage, just very easy to set up without any configuration. Though I did struggle with it a lot, the docs aren't overly detailed. Almost was underway to replace it with webpack, actually 😬

Thanks for the review, @jvntf and @geohacker !