v22: simplification 2.0 - Githubissues

catalyst-team / catalyst

Accelerated deep learning R&D

https://catalyst-team.com

Apache License 2.0

3.3k stars 388 forks source link

v22: simplification 2.0 #1395

Closed Scitator closed 2 years ago

Scitator commented 2 years ago

Pull Request FAQ

documentation
contribution guide
minimal examples section
changelog for main framework updates
Catalyst slack (#__questions channel) for issue discussion

Description

core architecture moved to Animus-like.
engines moved to Accelerate.
config/hydra APIs deprecated in favor of hydra-slayer-custom config runners.
dl-based scripts removed from the API, there is no need in them now
self-supervised runner moved to examples - it's better to have custom still
contrib and utils - truncated
requirements - simplified
codestyle moved to -l 89 (better view on 16'' screen ;) )

Related Issue

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

[ ] Have you updated tests for the new functionality?
[ ] Have you added your new classes/functions to the docs?
[ ] Have you updated the CHANGELOG?
[ ] Have you run colab minimal CI/CD with latest and minimal requirements?
[ ] Have you checked XLA integration with single and multiple processes?

pep8speaks commented 2 years ago

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file catalyst/loggers/wandb.py:

Line 225:87: E231 missing whitespace after ','

In the file catalyst/runners/__init__.py:

Line 12:1: E303 too many blank lines (3)

Comment last updated at 2022-01-26 05:47:43 UTC

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB