fix: reference to the moodle_org_token secret

catalyst / catalyst-moodle-workflows

4 stars 9 forks source link

fix: reference to the moodle_org_token secret #41

Closed keevan closed 2 years ago

keevan commented 2 years ago

Secrets cannot be used direcly in a conditional
Workaround is to pass it into a step in the ENV, and output some flag which can be used as a check thereafter
Also removed the default value for the secrets input, since it was an invalid field/property

Resolves #40

keevan commented 2 years ago

Tested here: https://github.com/catalyst/moodle-tool_dataflows/runs/6930584452?check_suite_focus=true

Using a draft PR pinned at the workflow branch: https://github.com/catalyst/moodle-tool_dataflows/pull/211

Related issue and solutions based on comments made here: https://github.com/actions/runner/issues/520

cameron1729 commented 2 years ago

If I understand correctly, this workaround doesn't entail a documentation change, right? That is, someone using this reusable workflow still only has to add the secret to their repo, and nothing else?

keevan commented 2 years ago

If I understand correctly, this workaround doesn't entail a documentation change, right? That is, someone using this reusable workflow still only has to add the secret to their repo, and nothing else?

Yes no changes to usage, just fixing an issue with the check / syntax which caused the whole workflow to stop running - an example here: https://github.com/catalyst/moodle-tool_dataflows/actions/runs/2513227928

cameron1729 commented 2 years ago

LGTM, and the test convinces me it's now working.