search

catalyst / catalyst-moodle-workflows

4 stars 9 forks source link

PHPCS checks to have an optional flag to force warnings to behave as errors #48

Closed keevan closed 2 years ago

keevan commented 2 years ago

This is particularly useful if you want the plugin repository to stay clean consistently and be 100% aligned with standards.

Bonus points if there was another option for a ratchet metric to be used, such that if the previous change/commit had X amount of issues, as long as the number of issues didn't increase, it would be considered as a pass, otherwise it would fail.

Noting that this is prone to changes in the moodle ci checker but that's a given.

keevan commented 2 years ago

Not sure if I've understood this 100% but perhaps the only thing needed is to change the warning severity to the same level as an error? --warning-severity=