search

catalyst / catalyst-moodle-workflows

4 stars 8 forks source link

Add a check to ensure version.php changes (e.g. a version bump / change) when CSS/JS, DB or lang string files are updated #49

Open keevan opened 2 years ago

keevan commented 2 years ago

Which ultimately results in less things that need to be manually reviewed, if it simply fails via the CI.

Example of note during a review: https://github.com/catalyst/moodle-tool_dataflows/pull/245#discussion_r910594806

Example of it being missed during review: https://github.com/catalyst/moodle-tool_dataflows/pull/249/files

The more things the reusable workflows can check, the less feedback loops we need during peer review whilst retaining quality. :smiley: :gem: