search

catalyst / catalyst-moodle-workflows

4 stars 9 forks source link

48 add configurable option for phpcs warnings as errors #50

Closed keevan closed 2 years ago

keevan commented 2 years ago

So I've tested this on the dataflows repository in particular:

No option set, expecting the defaults to PASS on codechecker WARNINGS: https://github.com/catalyst/moodle-tool_dataflows/runs/7296148234?check_suite_focus=true#step:3:1935

New option codechecker_max_warnings set, expecting it to FAIL on codechecker WARNINGS https://github.com/catalyst/moodle-tool_dataflows/runs/7296253313?check_suite_focus=true#step:3:1916

As expected, the CI fails after performing the codechecker run, when set as codechecker_max_warnings: 0, but passes otherwise.

Resolves #48

Tested using a commit that references the current branch of this repo: https://github.com/catalyst/catalyst-moodle-workflows/pull/50/commits/58c998fa080af1bf3f4d1aa900c23712e447639b