Closed keevan closed 2 years ago
So I've tested this on the dataflows repository in particular:
No option set, expecting the defaults to PASS on codechecker WARNINGS: https://github.com/catalyst/moodle-tool_dataflows/runs/7296148234?check_suite_focus=true#step:3:1935
New option codechecker_max_warnings set, expecting it to FAIL on codechecker WARNINGS https://github.com/catalyst/moodle-tool_dataflows/runs/7296253313?check_suite_focus=true#step:3:1916
codechecker_max_warnings
As expected, the CI fails after performing the codechecker run, when set as codechecker_max_warnings: 0, but passes otherwise.
codechecker_max_warnings: 0
Resolves #48
Tested using a commit that references the current branch of this repo: https://github.com/catalyst/catalyst-moodle-workflows/pull/50/commits/58c998fa080af1bf3f4d1aa900c23712e447639b
So I've tested this on the dataflows repository in particular:
No option set, expecting the defaults to PASS on codechecker WARNINGS: https://github.com/catalyst/moodle-tool_dataflows/runs/7296148234?check_suite_focus=true#step:3:1935
New option
codechecker_max_warnings
set, expecting it to FAIL on codechecker WARNINGS https://github.com/catalyst/moodle-tool_dataflows/runs/7296253313?check_suite_focus=true#step:3:1916As expected, the CI fails after performing the codechecker run, when set as
codechecker_max_warnings: 0
, but passes otherwise.Resolves #48
Tested using a commit that references the current branch of this repo: https://github.com/catalyst/catalyst-moodle-workflows/pull/50/commits/58c998fa080af1bf3f4d1aa900c23712e447639b