Consider adding tests against mysql database (not just mariadb)

keevan commented 2 years ago

There are some slight differences and those small differences can resolve in unit test / actual errors, so it would be good to capture them.

danmarsden commented 2 years ago

@keevan have you got some examples of failures? I'd be interested to know how wide the impact is here.

keevan commented 2 years ago

Hi @danmarsden, here are 2 I have in mind:

https://github.com/catalyst/moodle-tool_dataflows/issues/358
And https://github.com/ncstate-delta/moodle-mod_zoom/ for the run here which was OK, but failed tests on an mysql pipeline
```
There was 1 error:
```

1) mod_zoom\privacy\mod_zoom_provider_test::test_delete_data_for_users dml_write_exception: Error writing to database (You can't specify target table 'phpu_zoom_meeting_participants' for update in FROM clause DELETE FROM phpu_zoom_meeting_participants WHERE id IN (SELECT zmp.id FROM phpu_zoom_meeting_participants zmp JOIN phpu_zoom_meeting_details zmd ON zmd.id = zmp.detailsid JOIN phpu_zoom z ON zmd.zoomid = z.id JOIN phpu_modules m ON m.name = 'zoom' JOIN phpu_course_modules cm ON z.id = cm.instance AND m.id = cm.module JOIN phpu_context ctx ON ctx.instanceid = cm.id AND ctx.contextlevel = ? WHERE ctx.id = ? AND zmp.userid IN (?,?)) [array ( 0 => 70, 1 => 121001, 2 => '125000', 3 => '125001', )])


The later wasn't using our reusable workflows, but if it were it wouldn't have been caught either.

catalyst / catalyst-moodle-workflows

Consider adding tests against mysql database (not just mariadb) #65