At the moment phpmd and copy paste detector is always run but the output is ignored

catalyst / catalyst-moodle-workflows

4 stars 8 forks source link

At the moment phpmd and copy paste detector is always run but the output is ignored #67

Open brendanheywood opened 2 years ago

brendanheywood commented 2 years ago

Proposing:

[x] phpmd does NOT run by default - unlike others
[x] copy paste detector does run by default
[ ] If they run and error then they are an error
[ ] you can opt in or out depending on what they default to

keevan commented 2 years ago

+1 to everything, but on the fence about phpmd not running by default. Would it run by default eventually? e.g. once we get more agressive with code quality? Or will it always never run unless added to config?

Are there more pros to not running it at all vs running it in some sort of "inspect mode but passing?"

brendanheywood commented 2 years ago

it sounds good on paper but I suspect it is universally ignored. So we commit to fixing it, and then fix it, then turn it on, or we don't

If and when we turn md on then I think we will want to have a few vars to tune how sensitive it is

keevan commented 2 years ago

Okay I'm convinced. This would also make the checks simpler in line with point 3 mentioned in the main description.

dmitriim commented 2 years ago

+1 for triggering an error if one of the checks fails, but should be off by default.