Since errors were appearing (exit codes) later on, it wasn't obvious as to why the workflow was failing. Expanding the 'Moodle install output' block revealed underlying issues.
Rough brain dump, but it would be better if:
[ ] All CI steps should emit an exit code on success or failure
[ ] When they fail, their output should not be collapsed so it's more obvious to the end user what the issue is. This handling should be generic if possible (success = collapsed output, fail = show output)
https://github.com/catalyst/moodle-tool_fix_delete_modules/runs/7964502462
vs
https://github.com/catalyst/moodle-tool_fix_delete_modules/runs/7964502462?check_suite_focus=true#step:4:772 (referencing the section with issues)
Since errors were appearing (exit codes) later on, it wasn't obvious as to why the workflow was failing. Expanding the 'Moodle install output' block revealed underlying issues.
Rough brain dump, but it would be better if: