Improve file transfers

[christina-roperto]

Adding a few things:

• instead of checking fileid, this will now check artefact id as contentid. This is because artefacts can have the same fileid, so when it checked that fileid is the same, it skipped the artefact. https://github.com/catalyst/mahara-module_objectfs/blob/improve_file_transfers/objectfslib.php#L36-L46, the change would ensure it would be added/inserted to module_objectfs_objectfs
• setting $generateifpossible = false to avoid recursion/infinite loop (see related: https://bugs.launchpad.net/mahara/+bug/1776364)
• adding profileicon in a list of supported file

[azrek]

hi @christina-roperto

Can you also please bump up the version number of the plugin?

With the change from fileid to artefactid stored in the objectfs table, this is a major version change.

Version: 2022050300 release: 2.0.0

Thank you. Ghada

[azrek]

Hi @christina-roperto

Can you also add a new section in the Readme file about the change of the fileid to artefactid? We need to clarify the impact this will have on the stored files. Perhaps something like this (please modify as you see fit):

Release 2.0.0 impact

A major change in this release impacts all files stored in the module_objectfs_objects table. The ID stored in this table have changed from referencing the fileid to referencing the artefactid.

If you have moved files to S3 and have not deleted local files, it is recommended to delete all records in the module_objectfs_objects and initiate the upload again.

If you have moved files to S3 and have deleted local files, a script will need to be written to update the IDs from fileid to artefactid based on the file hash. This script has not been written in this release. We welcome merge requests to implement this change.

Thank you. Ghada

[christina-roperto]

Hi @azrek,

Thanks for the suggestion. I've updated the version and added that section in README. I didn't do any modification as it's perfect :)