catalyst / moodle-MDL-70329

GNU General Public License v3.0
5 stars 4 forks source link

mod_qbank - implement navigation for features #209

Open safatshahin opened 3 years ago

abonaccorso commented 3 years ago

Hi @safatshahin could you give me some information what this issue is about? I am asking because it sounds like we need some wireframes.

safatshahin commented 3 years ago

Hi @abonaccorso Thank you for your attention to this. This issue is related to adding the navigation in the mod_qbank settings menu, for example, this one from quiz: Screenshot 2021-07-26 19:37:08

mod_qbank will have options like this on the base view page. As it's not like the usual settings page of other activity plugins, we found some issues with it and this issue will introduce code changes to resolve and implement this option properly.

I hope my explanation was clear. Please let me know if I can help with any more information. A do apologise as the issue description seems really confusing.

Thanks

abonaccorso commented 3 years ago

Hi @safatshahin many thanks for your explanation. If I can help with the troubles in any way, let me know.

guillogo commented 3 years ago

Hi team,

This PR: https://github.com/catalyst/moodle-MDL-70329/pull/216 includes a solution in order to add the cog setting feature to the tab navigation. @safatshahin Can you please review this one? Thank you :)

image

guillogo commented 3 years ago

Note: The view above is mod_qbank. Also, it won't broke mod_quiz current view and was tested installing the export plugin.

abonaccorso commented 3 years ago

Hi @guillogo , looking at the screehshot above I wondered if the content of cog wheel (the list of options you have) is functional? I feel there is some points that are too much (but might be I am too early with this comment)

abonaccorso commented 3 years ago

Hi @guillogo here is my current thinking what whould be in the navigation (and what not)

grafik

I am not quite sure we need the "filter" as I don't know what it's doing. @timhunt do you know what the "Filter" is for?

And we still need to discuss if "Statistics" goes there - we have to discuss the whole statistics page and how it works first. Hope that helped.

guillogo commented 3 years ago

Thank you so much @abonaccorso that really helps.

timhunt commented 3 years ago

In Moodle, you can configure the text filters differently in different places. (E.g. you can have the Glossary auto-linking filter turned on in your course generally, but then you can disable it in the final Exam.)

So, this is a standard Moodle thing which we should leave where it is.

abonaccorso commented 3 years ago

Thank you @timhunt. So the filter will remain. @lucaboesch and I have been working on wireframes this afternoon and from our point of view, statistics should be in the question bank navigation as well. Where exactly can be discusses (for sure above filter, if you ask me).

Let me shortly explain regarding statistics: We talked about where to display question statistics last Tuesday. We decided NOT to include ALL quiz statistics except one in the question list. @timhunt suggested to have this one statistics column clickable to reach the detailed statistics report. One could either click on the statistic value itself - but here I would expect a detailed statistics report only for the specific question - not a statistic report for the whole question list. The column title would be another option. BUT in other tables clicking on the question table changes the sorting of the column. So the best option seems to be to reach the detailed statistics page for the questions list via question bank settings.

abonaccorso commented 3 years ago

So if there are no objections, from the UI point of view this issue is ready.

lucaboesch commented 3 years ago

So, @timhunt I agree "Filter" to remain in the quiz, of course. But what use is it in a question bank?

timhunt commented 3 years ago

Perhaps in your university, the way you organise questions banks means it is useful to be able to have the MathJax filter only enabled in the Maths question bank?